Welcome Guest! To enable all features please Login or Register.

Notification

Icon
Error

Tests impacted when only editing test comment?
GreenMoose
#1 Posted : Sunday, November 15, 2015 4:43:56 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 503

Thanks: 142 times
Was thanked: 66 time(s) in 64 post(s)
Hi.

Is it a technical reason (vs design decision?) for why tests are considered "impacted" even though the change only involves changing of code comments?

(The scenario is when I update test comments the tests are re-run when having "IsImpacted" engine mode condition. Ideally I would expect only changed covered code lines to trigger the "IsImpacted" condition).

Thanks.
Remco
#2 Posted : Sunday, November 15, 2015 6:06:30 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 6,979

Thanks: 931 times
Was thanked: 1257 time(s) in 1170 post(s)
Hi,

Yes. NCrunch's impact detection is currently very rudimentary, it works above the compiler step and does not consider the IL.

This has advantages in terms of simplicity and performance, but it isn't very accurate. Simply changing the code will trigger tests to be impacted, regardless of whether such a change actually impacts the compiled code.

IL-Level impact detection is expected as a future feature.
1 user thanked Remco for this useful post.
GreenMoose on 11/15/2015(UTC)
Users browsing this topic
Guest
Forum Jump  
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.

YAF | YAF © 2003-2011, Yet Another Forum.NET
This page was generated in 0.020 seconds.
Trial NCrunch
Take NCrunch for a spin
Do your fingers a favour and supercharge your testing workflow
Free Download