"Pin covering tests" not including tests if filter for showing passing tests is off

v 2.9.0.8

I have a method covered by 38 tests according to NCrunch green marker.
I have tests window filter set to only show failed tests.
I now select "pin covering tests", I only get those tests (6 of them) explicitly directly testing this method.
I now select enable filter to also show passing tests and redo the action, now all tests get pinned.
If I select "run covering tests" they are all run .

Submitted bug report if that helps.

Thanks for sharing this issue. When you choose to pin the covering tests (in both cases), how are you doing this? Is this done via context menu on the line of code?

Do you have the 'Show coverage for these tests only' filter active, or a filter set up on the code coverage itself via engine mode?

Remco wrote:Thanks for sharing this issue. When you choose to pin the covering tests (in both cases), how are you doing this? Is this done via context menu on the line of code?

I tried both just now via context menu and via keyboard shortcut. Same result.

Remco wrote:
Do you have the 'Show coverage for these tests only' filter active, or a filter set up on the code coverage itself via engine mode?

No.

I've had no luck reproducing this issue.

The code handling the assignment of pinned status of tests doesn't consider the Tests Window filters at all (there is no connection). There must be another variable involved. Do you perhaps have a search filter present? Can you reproduce this on a clean codebase?

Remco wrote:I've had no luck reproducing this issue.

The code handling the assignment of pinned status of tests doesn't consider the Tests Window filters at all (there is no connection). There must be another variable involved. Do you perhaps have a search filter present?

Nope.

Remco wrote:Can you reproduce this on a clean codebase?

I will see if I get time to set up a similar code structure for it, most likely not any time soon.

(The only drawback with this "bug" for me so far is it caused me to believe a method was not used by production code since no integration tests became pinned, so for me it isn't that big of a deal as long as I remember to use the context popup to verify usage instead of pinning)