Welcome Guest! To enable all features please Login or Register.

Notification

Icon
Error
Not identical at IL-level
Options
Previous Topic Next Topic
Silvenga
#1 Posted : Tuesday, December 20, 2016 3:05:03 PM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 1/24/2016(UTC)
Posts: 40
Location: United States of America

Was thanked: 3 time(s) in 3 post(s)
My team is currently running NCrunch on our projects - which includes the use of a grid server. Recently, we've found an odd warning that pops up on a single project (out of 24 right now) which can be found below:

Quote:
NCrunch has detected that compiled assemblies produced by different machines in the grid are not identical at IL-level. This is usually caused by grid machines using different compiler versions.


Since we are running VS2013 (waiting patiently for funding to upgrade), but wanted to use C# 6.0, we've been using the nuget package `Microsoft.Net.Compilers`. This package creates targets to override the ToolPath for csc to use the included out-of-band compilers, enabling new C# versions under old VS instances. Hence, in theory, the grid server should be using the same exact csc compilers to output the same IL code.

With the inclusion of IL level detection, my team has seen a definite improvement in impact detection (which we use primarily due to our machine CPU bottlenecks), so I'm trying to avoid downgrading to Text level detection.
Back to top
Remco
#2 Posted : Tuesday, December 20, 2016 10:12:37 PM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,145

Thanks: 960 times
Was thanked: 1290 time(s) in 1196 post(s)
Hi, thanks for sharing this issue.

NCrunch's IL-level impact detection works by generating a sequence of hashes from the assembly built for each project. The detection has no knowledge of language or syntax, and works only using the generated IL codes from the assembly.

So all it really knows here is that the assembly generated on your grid node is different in structure to the one built on your workstation. A difference in the compiler used is a possibility that should be investigated.

One way to analyse this issue further is to use ildasm.exe to obtain an IL-dump of the assembly on both your workstation and your grid server. You can then compare these IL dumps using a diff tool to see how the assemblies are different. For example:

ildasm myassembly /out:myassembly.il

You can do this with both NCrunch generated assemblies (which can be found by right-clicking on the project and choosing advanced->browse to workspace), and for assemblies built yourself by running MSBuild or VS on your workstation or grid node.
Back to top
 |  Edit by user
Silvenga
#3 Posted : Tuesday, December 20, 2016 11:18:46 PM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 1/24/2016(UTC)
Posts: 40
Location: United States of America

Was thanked: 3 time(s) in 3 post(s)
This was fun. So I took your suggestions and compared the differences and confirmed that the compiled IL is exactly the same except for a constant added by the compiler, see below:

The following code is for our logger using NLog:

Code:
Logger.Log(ToNLogLevel(level))
      .Property("Type", objectType)
      .Property("ObjectId", objectId)
      .Property("Area", area)
      .Message(message)
      .Write();

The write function under NLog has the following signature:
Code:

public void Write([CallerMemberName] string callerMemberName = null, [CallerFilePath] string callerFilePath = null, [CallerLineNumber] int callerLineNumber = 0)

It appears that the compiler is inserting the file path in place of the CallerLineNumberAttribute. As the remote server is building in a different path, the resulting IL code will be different.

Code:
      IL_0078:  callvirt   instance class [NLog]NLog.Fluent.LogBuilder [NLog]NLog.Fluent.LogBuilder::Message(string)
      IL_007d:  ldstr      "Write"
      IL_0082:  ldstr      "C:\\NCrunch Grid Node\\1168\\1614\\src\\<snip>"
      + "<snip>"
      IL_0087:  ldc.i4.s   99
      IL_0089:  callvirt   instance void [NLog]NLog.Fluent.LogBuilder::Write(string,
                                                                             string,
                                                                             int32)
Back to top
Remco
#4 Posted : Tuesday, December 20, 2016 11:25:28 PM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,145

Thanks: 960 times
Was thanked: 1290 time(s) in 1196 post(s)
Interesting. This looks like a new feature - https://msdn.microsoft.com/en-us/library/system.runtime.compilerservices.callerfilepathattribute(v=vs.110).aspx.

It wasn't on my radar.

I'll need to introduce special handling to exclude this from the impact detection hashing.

Thanks for making me aware of it!
Back to top
Remco
#5 Posted : Wednesday, December 21, 2016 7:08:36 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,145

Thanks: 960 times
Was thanked: 1290 time(s) in 1196 post(s)
Back to top
Silvenga
#6 Posted : Wednesday, December 21, 2016 2:05:20 PM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 1/24/2016(UTC)
Posts: 40
Location: United States of America

Was thanked: 3 time(s) in 3 post(s)
That was fast! I upgraded both the grid server and my local installation and it appears that the issue is still present. Below is a full diff of the two assemblies.

http://pastebin.com/bQzQKE67 (better formatting)
Back to top
Remco
#7 Posted : Wednesday, December 21, 2016 10:58:55 PM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,145

Thanks: 960 times
Was thanked: 1290 time(s) in 1196 post(s)
That's unfortunate. I'm having trouble viewing your paste, it seems to have been set to private. Is there any other way you can share it with me? Perhaps submitting it through the contact form?.
Back to top
Silvenga
#8 Posted : Thursday, December 22, 2016 12:25:55 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 1/24/2016(UTC)
Posts: 40
Location: United States of America

Was thanked: 3 time(s) in 3 post(s)
Remco;9629 wrote:
That's unfortunate. I'm having trouble viewing your paste, it seems to have been set to private. Is there any other way you can share it with me? Perhaps submitting it through the contact form?.


Oops, miss clicked. It should now be visible.
Back to top
Remco
#9 Posted : Tuesday, January 17, 2017 4:33:37 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,145

Thanks: 960 times
Was thanked: 1290 time(s) in 1196 post(s)
Sorry for the time it's taken me to come back to you on this one. The fix turned out to be a bit more complicated than I had expected.

I'm expecting to have a new build out later this week (v3.3). This build will contain a revised version of the fix that has been more thoroughly tested against NLog itself.
Back to top
Remco
#10 Posted : Wednesday, January 18, 2017 11:43:16 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,145

Thanks: 960 times
Was thanked: 1290 time(s) in 1196 post(s)
NCrunch v3.3 is now available including a fix for this issue - https://www.ncrunch.net/download.
Back to top
Users browsing this topic
Guest
Forum Jump  
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.

YAF | YAF © 2003-2011, Yet Another Forum.NET
This page was generated in 0.066 seconds.
Trial NCrunch
Take NCrunch for a spin
Do your fingers a favour and supercharge your testing workflow
Free Download