Welcome Guest! To enable all features please Login or Register.

Notification

Icon
Error

Impacted tests with internal types under CompareIL detection mode.
GreenMoose
#1 Posted : Wednesday, April 5, 2017 11:57:27 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 507

Thanks: 145 times
Was thanked: 66 time(s) in 64 post(s)
[v3.6.0.1]

From what I understand internal types are excluded from the impact detection engine, right? i.e. if I alter the some covered lines of an internal type, that will not mark tests covering those lines as impacted?
(And marking that assembly with [assembly: internalsVisibleTo("myTestAsembly')] does not seem to matter).

Is this planned to change in a near future?

I mostly declare types as internal with public interfaces and use IOC to resolve the instances. But this is not working with the IL impacted detection mode since tests are not treated as impacted, which is a pity since this is one awesomeness of NCrunch to only run impacted tests :/.

(Changing impact detection mode to CompareText works with internal types, but then all tests covering some line of the entire file is marked as impacted but I guess that is same behavior as before the CompareIL mode was introduced).

Thanks.
Remco
#2 Posted : Wednesday, April 5, 2017 12:05:43 PM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,161

Thanks: 964 times
Was thanked: 1296 time(s) in 1202 post(s)
GreenMoose
#3 Posted : Wednesday, April 5, 2017 12:56:37 PM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 507

Thanks: 145 times
Was thanked: 66 time(s) in 64 post(s)
Ok thanks. 3.7.0.3 did not fix the issue however (yes the method is async, and it behaves the same as before; e.g. commenting out a line: no impact detection, un-commenting a line/inserting a line: impact detection works).
Remco
#4 Posted : Wednesday, April 5, 2017 11:33:52 PM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,161

Thanks: 964 times
Was thanked: 1296 time(s) in 1202 post(s)
GreenMoose;10202 wrote:
Ok thanks. 3.7.0.3 did not fix the issue however (yes the method is async, and it behaves the same as before; e.g. commenting out a line: no impact detection, un-commenting a line/inserting a line: impact detection works).


Is there any chance you could isolate this issue with a sample project? I'd like to fill this hole if possible :)
GreenMoose
#5 Posted : Thursday, April 6, 2017 7:01:56 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 507

Thanks: 145 times
Was thanked: 66 time(s) in 64 post(s)
Remco;10204 wrote:
Is there any chance you could isolate this issue with a sample project? I'd like to fill this hole if possible :)

Sent via mail.
1 user thanked GreenMoose for this useful post.
Remco on 4/6/2017(UTC)
Remco
#6 Posted : Friday, April 7, 2017 5:46:49 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,161

Thanks: 964 times
Was thanked: 1296 time(s) in 1202 post(s)
GreenMoose
#7 Posted : Friday, April 7, 2017 12:49:01 PM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 507

Thanks: 145 times
Was thanked: 66 time(s) in 64 post(s)
Great! Works for my solution now as well :)
1 user thanked GreenMoose for this useful post.
Remco on 4/7/2017(UTC)
Users browsing this topic
Guest
Forum Jump  
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.

YAF | YAF © 2003-2011, Yet Another Forum.NET
This page was generated in 0.052 seconds.
Trial NCrunch
Take NCrunch for a spin
Do your fingers a favour and supercharge your testing workflow
Free Download