Welcome Guest! To enable all features please Login or Register.

Notification

Icon
Error
Multiple markers when renaming class with ReSharper
Options
Previous Topic Next Topic
alastairs
#1 Posted : Wednesday, May 17, 2017 7:49:05 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/13/2011(UTC)
Posts: 54
Location: Cambridge, UK

Thanks: 22 times
Was thanked: 4 time(s) in 4 post(s)
I'm using VS2017 Professional, NCrunch 3.7.0.7, ReSharper Ultimate 2017.1.1.

When I rename a class using ReSharper's rename feature, the file is renamed along with the class. Each rename results in the document being reloaded (I think) and a new set of coverage markers being added to the window.

I have tried reproducing this with a more simple manual rename of the class and the file, and it seems to be only the ReSharper functionality that triggers it. Closing and reopening the window resolves the issue and is an acceptable workaround.
Back to top
WWW
Remco
#2 Posted : Wednesday, May 17, 2017 9:59:12 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,161

Thanks: 964 times
Was thanked: 1296 time(s) in 1202 post(s)
Hi, thanks for sharing this problem.

Can you confirm whether you can reproduce this consistently using ReSharper rename? Does it ever work correctly when you do this?
Back to top
alastairs
#3 Posted : Friday, May 19, 2017 9:20:09 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/13/2011(UTC)
Posts: 54
Location: Cambridge, UK

Thanks: 22 times
Was thanked: 4 time(s) in 4 post(s)
Yes, it's reproducible consistently :)
Back to top
WWW
Remco
#4 Posted : Friday, May 19, 2017 12:10:14 PM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,161

Thanks: 964 times
Was thanked: 1296 time(s) in 1202 post(s)
alastairs;10412 wrote:
Yes, it's reproducible consistently :)


Thanks for confirming! I'll take a look :)
Back to top
b33rdy
#5 Posted : Friday, May 19, 2017 4:01:05 PM(UTC)
Rank: Member

Groups: Registered
Joined: 6/28/2016(UTC)
Posts: 20
Location: United Kingdom

Thanks: 17 times
Was thanked: 5 time(s) in 4 post(s)
I get this too, no R#, just standard VS rename refactor.
Back to top
1 user thanked b33rdy for this useful post.
Remco on 5/19/2017(UTC)
Remco
#6 Posted : Monday, May 22, 2017 2:55:32 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,161

Thanks: 964 times
Was thanked: 1296 time(s) in 1202 post(s)
I'm still having trouble reproducing this issue. I'm wondering if it might be caused by a race condition or sequence related issue somewhere, or perhaps surfaced by some specific configuration.

@b33rdy, you mentioned that you get this with a standard VS rename refactor, can you confirm whether you are running ReSharper or any of the JetBrains' tools in your environment? It would be useful if we can rule this out.

What do you have configured for your visual settings? Are you using line numbering or outlining? Do you have anything else added to your left margin? Are you running any other 3rd party plugins that introduce changes to the VS UI?
Back to top
alastairs
#7 Posted : Monday, May 22, 2017 10:10:41 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/13/2011(UTC)
Posts: 54
Location: Cambridge, UK

Thanks: 22 times
Was thanked: 4 time(s) in 4 post(s)
Remco;10440 wrote:
What do you have configured for your visual settings? Are you using line numbering or outlining? Do you have anything else added to your left margin? Are you running any other 3rd party plugins that introduce changes to the VS UI?


I have line numbering and Code Lens enabled in my C# editor windows. Other plugins I have installed that may be conflicting include OzCode and this Trailing Whitespace Visualiser. Everything else (apart from R#, obviously) appears to be out-of-the box Microsoft stuff.
Back to top
WWW
Remco
#8 Posted : Wednesday, May 24, 2017 6:30:15 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,161

Thanks: 964 times
Was thanked: 1296 time(s) in 1202 post(s)
@b33rdy: It would be really great to know if you see anything in Alastair's setup that is similar in yours. In this way, maybe I can rule out needing to test integration with some products.
Back to top
GreenMoose
#9 Posted : Wednesday, May 24, 2017 12:12:24 PM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 507

Thanks: 145 times
Was thanked: 66 time(s) in 64 post(s)
FWIW, happens with me as well when I rename with v3.8.0.2 https://www.screencast.com/t/IP6Hl3HQMqXL
I don't recall it happened previously, the recent changes I made are updating vstudio2017 and NCrunch.

(vstudio version info:
Quote:

Microsoft Visual Studio Enterprise 2017
Version 15.2 (26430.6) Release
VisualStudio.15.Release/15.2.0+26430.6
Microsoft .NET Framework
Version 4.6.01586

Installed Version: Enterprise

Architecture Diagrams and Analysis Tools 00369-60000-00001-AA973
Microsoft Architecture Diagrams and Analysis Tools

Visual Basic 2017 00369-60000-00001-AA973
Microsoft Visual Basic 2017

Visual C# 2017 00369-60000-00001-AA973
Microsoft Visual C# 2017

Visual C++ 2017 00369-60000-00001-AA973
Microsoft Visual C++ 2017

Visual F# 4.1 00369-60000-00001-AA973
Microsoft Visual F# 4.1

Application Insights Tools for Visual Studio Package 8.6.00404.2
Application Insights Tools for Visual Studio

ASP.NET and Web Tools 2017 15.0.30503.0
ASP.NET and Web Tools 2017

ASP.NET Web Frameworks and Tools 2017 5.2.50303.0
For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0 15.0.30209.0
Azure App Service Tools v3.0.0

Azure Data Lake Node 1.0
This package contains the Data Lake integration nodes for Server Explorer.

Azure Data Lake Tools for Visual Studio 2.2.5000.0
Microsoft Azure Data Lake Tools for Visual Studio

Common Azure Tools 1.9
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

JavaScript Language Service 2.0
JavaScript Language Service

JavaScript Project System 2.0
JavaScript Project System

JavaScript UWP Project System 2.0
JavaScript UWP Project System

JetBrains ReSharper Ultimate 2017.1.1 Build 108.0.20170407.122957
JetBrains ReSharper Ultimate package for Microsoft Visual Studio. For more information about ReSharper Ultimate, visit http://www.jetbrains.com/resharper. Copyright © 2017 JetBrains, Inc.

KofePackagePackage Extension 1.0
KofePackagePackage Visual Studio Extension Detailed Info

Merq 1.1.17-rc (cba4571)
Command Bus, Event Stream and Async Manager for Visual Studio extensions.

Microsoft Azure Hive Query Language Service 2.2.5000.0
Language service for Hive query

Microsoft Azure Tools 2.9
Microsoft Azure Tools for Microsoft Visual Studio 2017 - v2.9.50131.1

Microsoft MI-Based Debugger 1.0
Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual Studio VC Package 1.0
Microsoft Visual Studio VC Package

Mono Debugging for Visual Studio Mono.Debugging.VisualStudio
Support for debugging Mono processes with Visual Studio.

NCrunch
Continuous Testing Tool for .NET
Copyright © 2010-2016 Remco Software Ltd

NuGet Package Manager 4.2.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.

ReSharper.AutoFormatOnSave 1.0
Runs silent Reformat Code command upon file save.

SQL Server Data Tools 15.1.61702.140
Microsoft SQL Server Data Tools

ToolWindowHostedEditor 1.0
Hosting json editor into a tool window

TypeScript 2.2.2.0
TypeScript tools for Visual Studio

Visual Studio Spell Check Everywhere VSSpellCheckEverywhere
An extension that enables spell checking within any Visual Studio file editor or tool window that uses WPF text boxes.
https://GitHub.com/EWSoftware/VSSpellChecker

Visual Studio Spell Checker VSSpellChecker
An editor extension that checks the spelling of comments, strings, and plain text as you type or interactively with tool windows.
https://GitHub.com/EWSoftware/VSSpellChecker

Visual Studio Tools for Universal Windows Apps 15.0.26430.06
The Visual Studio Tools for Universal Windows apps allow you to build a single universal app experience that can reach every device running Windows 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 Software Development Kit.

Web Extension Pack 2017 15.0.2
The easiest way to set up Visual Studio for the ultimate web development experience.

Xamarin 4.5.0.443 (c871575)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin.Android SDK 7.3.0.13 (448f54f)
Xamarin.Android Reference Assemblies and MSBuild support.

Xamarin.iOS and Xamarin.Mac SDK 10.10.0.30 (30b6e87)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

)
Back to top
 |  Edit by user
Remco
#10 Posted : Monday, June 19, 2017 11:04:56 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,161

Thanks: 964 times
Was thanked: 1296 time(s) in 1202 post(s)
Back to top
1 user thanked Remco for this useful post.
GreenMoose on 6/20/2017(UTC)
GreenMoose
#11 Posted : Tuesday, June 20, 2017 6:36:18 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 507

Thanks: 145 times
Was thanked: 66 time(s) in 64 post(s)
I have tried with 3.10.0.2 / vs2017 above and it seems to have resolved the issue for me!

What I noted when trying to produce a stable repro before upgrading are:
* It only happened if I had Solution Explorer visible.
* It only happened when I rename file via RS (Ctrl+R,Ctrl+R), renaming the file via Solution Explorer (F2) did not reproduce the issue.
Back to top
Remco
#12 Posted : Tuesday, June 20, 2017 8:25:38 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,161

Thanks: 964 times
Was thanked: 1296 time(s) in 1202 post(s)
GreenMoose;10661 wrote:
I have tried with 3.10.0.2 / vs2017 above and it seems to have resolved the issue for me!


Horray! Hopefully others here can also confirm if they still see the issue.
Back to top
Users browsing this topic
Guest
Forum Jump  
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.

YAF | YAF © 2003-2011, Yet Another Forum.NET
This page was generated in 0.144 seconds.
Trial NCrunch
Take NCrunch for a spin
Do your fingers a favour and supercharge your testing workflow
Free Download