Tests utilising Microsoft.AspNet.TestHost i.c.w. MVC Views fail in NCrunch

jp7677

#10583 9 years ago 12 Jun 2017 09:40 UTC

Hi there,

As a follow-up to http://forum.ncrunch.net/yaf_postst2142_Tests-utilising-Microsoft-AspNet-TestHost-fail-in-NCrunch.aspx, there is still a case where ncrunch fails to successfully execute unit test. That case would be compilation of mvc views.

I have a reproduction repository here:
https://github.com/jp7677/ncrunchbugrepro

There are two testcases, one is a normal MVC Controller, that one succeeds with the latest ncrunch version. The second test involves MVC view compilation. This one fails in ncrunch, but succeeds on the command line. Note that there is a workaround in the csproj file for the test project (https://github.com/jp7677/ncrunchbugrepro/blob/master/NCrunchBugRepro.Test/NCrunchBugRepro.Test.csproj), taken from https://github.com/NuGet/Home/issues/4412.

If I apply this workaround manually to nrcunch, thus copying the NCrunchBugRepro.deps.json into the ncrunch test, ncrunch can successfully execute the test.
Thus I guess a solution would be that the mode "Copy Referenced Assemblies To Workspace" should also include deps.json files.

Regards and thanks for creating and supporting ncrunch!
Jens

Remco NCrunch Developer

#10584 9 years ago 12 Jun 2017 10:37 UTC

Hi Jens,

Thanks for sharing the extension to this issue. I believe you are correct in that copying the .deps files over when 'Copy referenced assemblies to workspace' is enabled would be the correct solution here. I'll see what I can do about arranging a fix.

jp7677

#10586 9 years ago 12 Jun 2017 12:55 UTC

Thanks for the fast response! Nice to read that and looking forward to a solution.

Remco NCrunch Developer

#10632 9 years ago 16 Jun 2017 04:05 UTC

jp7677

#10634 9 years ago 16 Jun 2017 11:32 UTC

Thanks a lot. works perfectly for my scenarios.
Though I have noticed that view compilation inside ncrunch still fails when one references other projects directly inside the views.

Remco NCrunch Developer

#10640 9 years ago 17 Jun 2017 01:29 UTC

jp7677 wrote:Thanks a lot. works perfectly for my scenarios.
Though I have noticed that view compilation inside ncrunch still fails when one references other projects directly inside the views.

Thanks. I'll see if I can get this sorted in the next dev build.

Remco NCrunch Developer

#10647 9 years ago 19 Jun 2017 11:05 UTC

jp7677

#10648 9 years ago 19 Jun 2017 12:37 UTC

How convenient, I had just updated my reproduction repository at https://github.com/jp7677/ncrunchbugrepro for my latest issue here with directly referenced projects in MVC pages ;)
Unfortunately ncrunch (3.10.0.2) still fails to run my second test while "dotnet test" on the command line succeeds, please see my repository.

Remco NCrunch Developer

#10721 9 years ago 29 Jun 2017 07:43 UTC

jp7677

#10732 9 years ago 03 Jul 2017 07:59 UTC

Hi there, thanks for version 3.10.0.6. Unfortunately my second issue reported here (posting #8) is not yet fixed on my machine with that version.

Remco NCrunch Developer

#10733 9 years ago 03 Jul 2017 09:53 UTC

jp7677 wrote:Hi there, thanks for version 3.10.0.6. Unfortunately my second issue reported here (posting #8) is not yet fixed on my machine with that version.

Sorry, I should have clarified this. For the fix to work, you'll need to turn on the 'Copy referenced assemblies to workspace' setting for all projects in the dependency chain. NCrunch will implicitly turn this on for any projects that reference AspNet.TestHost, but it can't do this automatically for projects deeper down the chain.

jp7677

#10734 9 years ago 03 Jul 2017 10:20 UTC

Remco wrote:For the fix to work, you'll need to turn on the 'Copy referenced assemblies to workspace' setting for all projects in the dependency chain.

Yes, that did the trick, thanks a lot!

Remco NCrunch Developer

#10791 9 years ago 18 Jul 2017 01:18 UTC

NCrunch v3.10 has now been released.

Post a reply