Welcome Guest! To enable all features please Login or Register.

Notification

Icon
Error

NCrunch 3.23 does not
Der-Albert.com
#1 Posted : Monday, January 14, 2019 9:40:12 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 5/17/2011(UTC)
Posts: 171

Thanks: 8 times
Was thanked: 37 time(s) in 34 post(s)
I've updated to NCrunch 3.23.0.10, on the Grid Node first and in VS 2017.
But there is a regression in there.

There is Directory.build.props file in the Solution. The Content is simple

Code:
<Project>
  <PropertyGroup>
    <LangVersion>latest</LangVersion>
  </PropertyGroup>
</Project>

This set the LangVersion for all Projects to latest, because it sucks to do it in every projects. The are
additional props file, but only for test projects. The failing of building was also in the normale projects.

The Structure is like that (in reality it is a little bit more complicated, not my idea)
|
|-src
| |- ProjectA
| | |- ProjectA.csproj
| |- ProjectB
| |- ProjectB.csproj
| Directory.build.props
Solution.sln

After Upgrading to 3.23 every Project which used newer C# Feature failed to build. Such things
happens sometimes after upgrades so i restartet the Host Machine of the Grid Node. Problem still
present, i restarted my machine, problem sill present. I restarted the NCrunch Endinge and Synchronised the
with VS each time. Problem still happend. NCrunch was not picking up the Directory.builds.props file.

So i decided to run Tests locally on my machine, and all projects are build and tests are run (while starting
writing this post). My plan was to switch back to the Grid Node and add the props files to additional files.

I switch back to the Grid Node, and now it is building fine (Restarting the Engine), and the tests are also fine.
Without adding the props file.

I know the reproducability is hard. But i decided to inform you about it anyway. I can work now ;)

Best Regards

Albert




1 user thanked Der-Albert.com for this useful post.
GreenMoose on 1/14/2019(UTC)
Remco
#2 Posted : Monday, January 14, 2019 10:42:19 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 5,722

Thanks: 744 times
Was thanked: 950 time(s) in 905 post(s)
Hi Albert,

Thanks for sharing this problem. Off the top of my head, I can't think of anything we changed in 3.23 that would affect Directory.build.props resolution, and I'm certain we have tests covering this use case. Is it at all possible for you to try downgrading to 3.22 to confirm for me whether this is a regression or a new problem of some kind? Knowing the difference will help us with discovering how to fix this problem.
Der-Albert.com
#3 Posted : Thursday, January 17, 2019 2:41:51 PM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 5/17/2011(UTC)
Posts: 171

Thanks: 8 times
Was thanked: 37 time(s) in 34 post(s)
Was not able to reproduce the problem.
Remco
#4 Posted : Thursday, January 17, 2019 10:26:49 PM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 5,722

Thanks: 744 times
Was thanked: 950 time(s) in 905 post(s)
Der-Albert.com;13005 wrote:
Was not able to reproduce the problem.


Thanks for confirming. Do let us know if you find a way to get it happening in a sample.
Users browsing this topic
Guest
Forum Jump  
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.

YAF | YAF © 2003-2011, Yet Another Forum.NET
This page was generated in 0.031 seconds.