Welcome Guest! To enable all features please Login or Register.

Notification

Icon
Error
"Pin covering tests" not including tests if filter for showing passing tests is off
Options
Previous Topic Next Topic
GreenMoose
#1 Posted : Wednesday, September 17, 2014 2:43:55 PM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 507

Thanks: 145 times
Was thanked: 66 time(s) in 64 post(s)
v 2.9.0.8

I have a method covered by 38 tests according to NCrunch green marker.
I have tests window filter set to only show failed tests.
I now select "pin covering tests", I only get those tests (6 of them) explicitly directly testing this method.
I now select enable filter to also show passing tests and redo the action, now all tests get pinned.
If I select "run covering tests" they are all run .

Submitted bug report if that helps.
Back to top
Remco
#2 Posted : Wednesday, September 17, 2014 10:01:57 PM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,144

Thanks: 959 times
Was thanked: 1290 time(s) in 1196 post(s)
Thanks for sharing this issue. When you choose to pin the covering tests (in both cases), how are you doing this? Is this done via context menu on the line of code?

Do you have the 'Show coverage for these tests only' filter active, or a filter set up on the code coverage itself via engine mode?
Back to top
GreenMoose
#3 Posted : Thursday, September 18, 2014 5:54:41 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 507

Thanks: 145 times
Was thanked: 66 time(s) in 64 post(s)
Remco;6416 wrote:
Thanks for sharing this issue. When you choose to pin the covering tests (in both cases), how are you doing this? Is this done via context menu on the line of code?

I tried both just now via context menu and via keyboard shortcut. Same result.
Remco;6416 wrote:

Do you have the 'Show coverage for these tests only' filter active, or a filter set up on the code coverage itself via engine mode?

No.
Back to top
Remco
#4 Posted : Thursday, September 18, 2014 6:00:41 AM(UTC)
Rank: NCrunch Developer

Groups: Administrators
Joined: 4/16/2011(UTC)
Posts: 7,144

Thanks: 959 times
Was thanked: 1290 time(s) in 1196 post(s)
I've had no luck reproducing this issue.

The code handling the assignment of pinned status of tests doesn't consider the Tests Window filters at all (there is no connection). There must be another variable involved. Do you perhaps have a search filter present? Can you reproduce this on a clean codebase?
Back to top
GreenMoose
#5 Posted : Thursday, September 18, 2014 6:07:54 AM(UTC)
Rank: Advanced Member

Groups: Registered
Joined: 6/17/2012(UTC)
Posts: 507

Thanks: 145 times
Was thanked: 66 time(s) in 64 post(s)
Remco;6420 wrote:
I've had no luck reproducing this issue.

The code handling the assignment of pinned status of tests doesn't consider the Tests Window filters at all (there is no connection). There must be another variable involved. Do you perhaps have a search filter present?

Nope.
Remco;6420 wrote:
Can you reproduce this on a clean codebase?

I will see if I get time to set up a similar code structure for it, most likely not any time soon.

(The only drawback with this "bug" for me so far is it caused me to believe a method was not used by production code since no integration tests became pinned, so for me it isn't that big of a deal as long as I remember to use the context popup to verify usage instead of pinning)
Back to top
1 user thanked GreenMoose for this useful post.
Remco on 9/18/2014(UTC)
Users browsing this topic
Guest
Forum Jump  
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.

YAF | YAF © 2003-2011, Yet Another Forum.NET
This page was generated in 0.047 seconds.
Trial NCrunch
Take NCrunch for a spin
Do your fingers a favour and supercharge your testing workflow
Free Download