Hi,
I already submitted an issue via VS directly, after updating to NCrunch v4 (all cashes are cleared, vs restarted multiple times) one project fails to build (switching back to Default/Legacy Instrumentation Mode makes NCrunch working again).

BTW: We are using sdk-based project files with .NET 4.7.2.

Here is the source code that seems to break NCrunch (inkl. the Interface):

public interface IIdGenerationRepository<TIdItem> where TIdItem : class, IIdItem
{
#region Public Methods

[SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate")]
Task<int> GetNextIdAsync();

#endregion
}


public class IdGenerationRepository<TIdItem> : IIdGenerationRepository<TIdItem>
where TIdItem : class, IIdItem
{
#region Private Fields

//Hier wird immer 1 genommen, da die Implementierung vom _repository.Create eine Id verlangt.
//Diese wird nicht gespeichert und auch nicht in der Implementierung verwendet.
private const string Id = "1";

private readonly IRepository<TIdItem> _repository;

#endregion

#region Initialization

public IdGenerationRepository(IRepository<TIdItem> repository)
{
_repository = repository;
}

#endregion

#region Interface Implementation: IIdGenerationRepository<TIdItem>

public async Task<int> GetNextIdAsync()
{
TIdItem idItemEF = _repository.Create(Id);

await _repository.SaveAsync(idItemEF);

return idItemEF.ConsecutiveNumber;
}

#endregion
}


[15:37:20.8093-LocalBuildTask-79] ERROR (Internal): nCrunch.Compiler.NewStaticManipulation.CilTypeHashException: Unable to hash type 'Upper.DistributionManager.Data.IdGenerationRepository`1' due to exception: System.IndexOutOfRangeException: Index was outside the bounds of the array.
at nCrunch.Compiler.Cil.Types.CilTypeDefTable.GetRowByMethodDefIndex(UInt32 methodDefTableRowIndex)
at nCrunch.Compiler.Cil.Methods.CilMethodDefinition.TryResolveASyncTarget()
at nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.(Boolean , ClassMethodData , Dictionary`2 , CilTypeDefinition , FNV64& , CilMethodDefinition )
at nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.ExtractClassMethodData(TestFrameworkDescription[] applicableTestFrameworks, IDictionary`2 codeFileIDsByForegroundFilePath, Boolean storeImpactHashes)
at nCrunch.Compiler.CilProcessingTasks.ConcurrentCilTaskProcessor.ProcessTasks(Int32 backgroundThreadsAllowed)
at nCrunch.Compiler.RemoteBuildRunner.(ComponentInstrumentationParameters , BuildOutput , IBackgroundTaskProcessor )
at nCrunch.Compiler.RemoteBuildRunner.PerformPostProcessingOfBuiltAssembly(ComponentInstrumentationParameters instrumentationParameters, BuildOutput output, IBackgroundTaskProcessor backgroundTaskProcessor)
at nCrunch.Core.BuildManagement.BuildEnvironment..()
at nCrunch.Common.PerformanceTracking.PerfTracker.TrackActivity(String name, Action activity)
at nCrunch.Core.BuildManagement.BuildEnvironment.Build(SnapshotComponent snapshotComponentToBuild, IList`1 referencedComponents, GridClientId gridClientId, IList`1 customEnvironmentVariables, IPlatformBuildExtender extender, Guid taskId, GridAddress clientAddress)
at nCrunch.Core.Processing.BuildTaskLogic.DoProcessTaskAndReturnSuccessFlag()
at nCrunch.Core.Processing.TaskLogic.ProcessTaskAndReturnSuccessFlag()
at nCrunch.Client.Processing.LocalProcessingTask.ProcessTaskAndReturnSuccessFlag()
at nCrunch.Client.Processing.ProcessingQueue..()

Please let me know if I can help to fix the issue.

br
Renè

We get the same error (obviously for a different class!). Have also submitted a bug report

I'm not OP but I could consistently reproduce this problem with 4.0.0.2. Upgrading to 4.0.0.3 has resolved the issue for me.

Fixes it for us too. Thanks

Also have a problem on 4.1.0.1 with optimized builds enabled. Bug report submitted.

Thanks everyone for these stacktraces. I'm building a list of issues with the new optimised mode right now with a plan to work through these early in the coming week. If you experience any other exceptions that aren't shown here, please do share them so we can get them fixed quickly.

I'll let you know as soon as we can make a new build available with fixes. Switching back to legacy mode should be an effective workaround for now. Note that under advanced configuration, you should be able to do this on a per-project basis.

Tried NCrunch_VS2019_4.2.0.1.msi

Still getting a build error.
Submitted bug report.
Solution can be found at
https://github.com/SimControl/SimControl.Reactive

[10:02:49.2611-LocalBuildTask-37] ERROR: System.Exception: Unable to instrument type SimControl.Templates.CSharp.OldClassLibrary.Class1 due to exception: System.Exception: Unable to instrument method System.Void SimControl.Templates.CSharp.OldClassLibrary.Class1::.ctor() due to exception: System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
bei nCrunch.Compiler.Cil.Utility.CilAddress.ReadCompressedUInt32AndAdvance()
bei nCrunch.Compiler.Cil.Symbols.Portable.CilPortableSequencePointEnumerator..ctor(CilAddress blobAddress, UInt32 documentRowIndex)
bei nCrunch.Compiler.Cil.Symbols.Portable.CilPortableSequencePointIndex.TryIndexMethodSequencePoints(CilMethodBody methodBody, UInt32 methodTableRowIndex)
bei nCrunch.Compiler.Cil.Methods.CilMethodDefinition.IndexSequencePoints(ICilSequencePointIndex index)
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.(CilManipulationOperation , CilMethodDefinition , CilTypeDefinition , CilMethodBody , Boolean )
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.(CilTypeDefinition , InstrumentationOutput , CilManipulationOperation , IInstrumentationFilter[] )
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.(CilTypeDefinition , InstrumentationOutput , CilManipulationOperation , IInstrumentationFilter[] )
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly..()
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly..()
bei nCrunch.Common.PerformanceTracking.PerfTracker.TrackActivity(String name, Action activity)
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly..()
bei nCrunch.Common.PerformanceTracking.PerfTracker.TrackActivity(String name, Action activity)
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.Instrument(IInstrumentationFilter[] instrumentationFilters, PerfTracker perfTracker)
bei nCrunch.Compiler.CilProcessingTasks.CilInstrumentationTask.ProcessTask(IBuiltAssembly builtAssembly, ComponentInstrumentationParameters instrumentationParameters, BuildOutput output)
bei nCrunch.Compiler.CilProcessingTasks.ConcurrentCilTaskProcessor.()
[10:02:49.2611-LocalBuildTask-37] ERROR: nCrunch.Compiler.NewStaticManipulation.CilTypeHashException: Unable to hash type 'SimControl.Templates.CSharp.OldClassLibrary.Class1' due to exception: System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
bei nCrunch.Compiler.Cil.Utility.CilAddress.ReadCompressedUInt32AndAdvance()
bei nCrunch.Compiler.Cil.Symbols.Portable.CilPortableSequencePointEnumerator..ctor(CilAddress blobAddress, UInt32 documentRowIndex)
bei nCrunch.Compiler.Cil.Symbols.Portable.CilPortableSequencePointHandler.GetFirstRelevantSequencePoint(CilMethodBody methodBody, UInt32 methodTableRowIndex)
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.(Boolean , ClassMethodData , Dictionary`2 , CilTypeDefinition , FNV64& , CilMethodDefinition )
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.ExtractClassMethodData(TestFrameworkDescription[] applicableTestFrameworks, IDictionary`2 codeFileIDsByForegroundFilePath, Boolean storeImpactHashes)
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.ExtractClassMethodData(TestFrameworkDescription[] applicableTestFrameworks, IDictionary`2 codeFileIDsByForegroundFilePath, Boolean storeImpactHashes)
bei nCrunch.Compiler.CilProcessingTasks.CilMethodHashingTask..()
bei nCrunch.Common.PerformanceTracking.PerfTracker.TrackActivity(String name, Action activity)
bei nCrunch.Compiler.CilProcessingTasks.ConcurrentCilTaskProcessor.()
[10:02:49.2813-LocalBuildTask-37] ERROR (Internal): System.Exception: nCrunch.Compiler.NewStaticManipulation.CilTypeHashException: Unable to hash type 'SimControl.Templates.CSharp.OldClassLibrary.Class1' due to exception: System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
bei nCrunch.Compiler.Cil.Utility.CilAddress.ReadCompressedUInt32AndAdvance()
bei nCrunch.Compiler.Cil.Symbols.Portable.CilPortableSequencePointEnumerator..ctor(CilAddress blobAddress, UInt32 documentRowIndex)
bei nCrunch.Compiler.Cil.Symbols.Portable.CilPortableSequencePointHandler.GetFirstRelevantSequencePoint(CilMethodBody methodBody, UInt32 methodTableRowIndex)
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.(Boolean , ClassMethodData , Dictionary`2 , CilTypeDefinition , FNV64& , CilMethodDefinition )
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.ExtractClassMethodData(TestFrameworkDescription[] applicableTestFrameworks, IDictionary`2 codeFileIDsByForegroundFilePath, Boolean storeImpactHashes)
bei nCrunch.Compiler.NewStaticManipulation.BuiltCilAssembly.ExtractClassMethodData(TestFrameworkDescription[] applicableTestFrameworks, IDictionary`2 codeFileIDsByForegroundFilePath, Boolean storeImpactHashes)
bei nCrunch.Compiler.CilProcessingTasks.CilMethodHashingTask..()
bei nCrunch.Common.PerformanceTracking.PerfTracker.TrackActivity(String name, Action activity)
bei nCrunch.Compiler.CilProcessingTasks.ConcurrentCilTaskProcessor.()
bei nCrunch.Compiler.CilProcessingTasks.ConcurrentCilTaskProcessor.ProcessTasks(Int32 backgroundThreadsAllowed)
bei nCrunch.Compiler.RemoteBuildRunner.(ComponentInstrumentationParameters , BuildOutput , IBackgroundTaskProcessor )
bei nCrunch.Compiler.RemoteBuildRunner.PerformPostProcessingOfBuiltAssembly(ComponentInstrumentationParameters instrumentationParameters, BuildOutput output, IBackgroundTaskProcessor backgroundTaskProcessor)
bei nCrunch.Core.BuildManagement.BuildEnvironment..()
bei nCrunch.Common.PerformanceTracking.PerfTracker.TrackActivity(String name, Action activity)
bei nCrunch.Core.BuildManagement.BuildEnvironment.Build(SnapshotComponent snapshotComponentToBuild, IList`1 referencedComponents, GridClientId gridClientId, IList`1 customEnvironmentVariables, IPlatformBuildExtender extender, Guid taskId, GridAddress clientAddress)
bei nCrunch.Core.Processing.BuildTaskLogic.DoProcessTaskAndReturnSuccessFlag()
bei nCrunch.Core.Processing.TaskLogic.ProcessTaskAndReturnSuccessFlag()
bei nCrunch.Client.Processing.LocalProcessingTask.ProcessTaskAndReturnSuccessFlag()
bei nCrunch.Client.Processing.ProcessingQueue..()

Thanks for sharing this.

I think the reason we're seeing problems with this solution is because of the IL weaver(s) used by the logging. This weavers are not necessarily in error, but they do result in a different assembly structure to what we've been testing with.

I've tried to do some testing with the solution myself, but I can't seem to get it to build in VS. Is there any guidance available for building the solution on a fresh checkout? Or is there any chance you might be able to provide me with some pre-built binaries to perform testing with?

Hello,

Can also confirm that the 4.2 build linked above seems to have resolved the "1 project failed to build" issue I was having with multiple classic .NET Framework solutions.

Thanks!

Thanks for sharing this. Can you confirm whether you experience this with the latest version of NCrunch? We've been rolling out CIL-related fixes with great frequency in the newer builds.